-
Notifications
You must be signed in to change notification settings - Fork 964
document new cookie behavior: type: express
as default, and new algolia behavior
#1806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1806.quarto.org 🔄 Modified Documents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Comments are all about what the default behaviour for cookie-consent: true
is. I don't want us to imply that cookies are opt-in until that is true. We either wait until the defauly behavior is changed, or change examples to explicitly set type: express
.
docs/websites/website-search.qmd
Outdated
|
||
- **Default behavior (no cookies)**: A random session token is generated for each browser session. This allows tracking of search interactions during a single visit without storing persistent cookies. This default is compliant with privacy regulations like GDPR. | ||
|
||
- **Persistent tracking (with cookies)**: To track users across multiple sessions, you must enable [cookie consent](website-tools.qmd#cookie-consent). When cookie consent is enabled, Algolia will only use cookies after the user grants "tracking" consent: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... after the user grants "tracking" consent
This won't be true until the default behavior for cookie-consent: true
is type: express
. We could omit, or wait to merge.
Or maybe:
- **Persistent tracking (with cookies)**: To track users across multiple sessions, you must enable [cookie consent](website-tools.qmd#cookie-consent). When cookie consent is enabled, Algolia will only use cookies after the user grants "tracking" consent: | |
- **Persistent tracking (with cookies)**: To track users across multiple sessions, you must enable [cookie consent](website-tools.qmd#cookie-consent). When cookie consent is enabled, Algolia will use cookies based on settings for `cookie-consent`: |
docs/websites/website-tools.qmd
Outdated
analytics-events: true | ||
``` | ||
|
||
Note that with cookie consent enabled, both Google Analytics and Algolia search analytics will only use cookies after the user has granted "tracking" consent. Without cookie consent enabled, Algolia will use session-only tracking without cookies. See [Algolia Insights](/docs/websites/website-search.qmd#algolia-insights) for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after the user has granted "tracking" consent
Same problem here.
The default type change is in there: Probably worth a 1.9 highlight ? or just breaking change bullet in changelog ? |
Definitely needs to be a 1.9 highlight. |
type: express
as defaumt, and new algolia behavior
@cwickham I have done the update in this PR regarding new 'express' default. I also added a highlight. I tried to rework (with Claude's help) some of the wording to mention the regulation-ready without being too much about compliance, as we don't want to definitive on this. |
type: express
as defaumt, and new algolia behaviortype: express
as default, and new algolia behavior
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1806.quarto.org 🔄 Modified Documents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Charlotte Wickham <[email protected]>
Thank you ! |
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1806.quarto.org 🔄 Modified Documents |
Doc for quarto-dev/quarto-cli#13525
This PR details the cookie consent logic with
analytics-event: true
and the requirement forcookie-consent: true